Bot layer: §10.10 MUSTs (command router, mention addressing) and bot-default drifts #97

New issue

Closed

opened 2026-08-13 21:36:21 +02:00 by thecrealm · 0 comments

thecrealm commented

2026-08-13 21:36:21 +02:00

Owner

Review findings, three items:

katrix-bot public surface is onMessage/autojoin/reply/run only. §10.10:11,17-19 MUST command routing and mention-addressing. No deferral record exists — build or defer+record.
MatrixBot connects without a sendConfig, so bots run STRICT_PER_ROOM while spec §10.5.2 declares related-only the bot default (D22 named it 'bot default' too). Fix the default or amend the spec.
MatrixBot.kt:90,102 constructs a ktor HttpClient() as a default argument value — a second HTTP-client construction site vs §3.2's the-transport-is-the-only-HTTP rule (signature stays clean since the parameter type is HttpPort, but the default instantiates ktor in katrix-bot). Route through a transport-provided default or record the exception.

Review findings, three items: 1. katrix-bot public surface is onMessage/autojoin/reply/run only. §10.10:11,17-19 MUST command routing and mention-addressing. No deferral record exists — build or defer+record. 2. MatrixBot connects without a sendConfig, so bots run STRICT_PER_ROOM while spec §10.5.2 declares related-only the bot default (D22 named it 'bot default' too). Fix the default or amend the spec. 3. MatrixBot.kt:90,102 constructs a ktor HttpClient() as a default argument value — a second HTTP-client construction site vs §3.2's the-transport-is-the-only-HTTP rule (signature stays clean since the parameter type is HttpPort, but the default instantiates ktor in katrix-bot). Route through a transport-provided default or record the exception.

thecrealm added the

labels

2026-08-13 22:25:19 +02:00

thecrealm referenced this issue

2026-08-23 00:02:39 +02:00

Push-rule evaluator (§10.3.5): local evaluation of m.push_rules, signals with actions, LOCAL unread from notifying events #118

thecrealm referenced this issue from a commit

2026-08-23 00:37:29 +02:00

Bot layer: command router on push-rule mention semantics, related-only default, one HTTP-client site (D66, closes #97)

thecrealm closed this issue

2026-08-23 00:37:29 +02:00