Send queue: transmit-time relation splice only handles media parents (§10.5.2) #91

Closed
opened 2026-08-13 21:35:53 +02:00 by thecrealm · 0 comments
Owner

Review finding. SendQueue.kt:619-641 resolves dependent content only for SendItemKind.MEDIA_UPLOAD parents. An edit/reaction enqueued with dependsOn against a not-yet-accepted parent transmits with an unresolvable m.relates_to.event_id. D22 asserts media-to-event AND edit/reaction-to-parent are single-parent chains; spec §10.5.2 MUSTs that relations on a not-yet-accepted parent resolve when the parent lands. Implemented for media only; no test covers the relation case.

Also from the §3.5 sketch: SendHandle has no edit/react operations — decide whether to add them or record their absence (D-entry).

Acceptance: relation-target splice for non-media parents + test; §10.5.2 CR coverage.

Review finding. SendQueue.kt:619-641 resolves dependent content only for SendItemKind.MEDIA_UPLOAD parents. An edit/reaction enqueued with dependsOn against a not-yet-accepted parent transmits with an unresolvable m.relates_to.event_id. D22 asserts media-to-event AND edit/reaction-to-parent are single-parent chains; spec §10.5.2 MUSTs that relations on a not-yet-accepted parent resolve when the parent lands. Implemented for media only; no test covers the relation case. Also from the §3.5 sketch: SendHandle has no edit/react operations — decide whether to add them or record their absence (D-entry). Acceptance: relation-target splice for non-media parents + test; §10.5.2 CR coverage.
thecrealm added
now
and removed
next
labels 2026-08-21 11:20:23 +02:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
thecrealm/katrix#91
No description provided.