Fix SqliteReplayEquivalenceTest: iterate polling sources only, not SyncSourceId.entries #101
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Found 2026-08-21 while running :katrix-store-sqlite:jvmTest locally for #91. The test loops over SyncSourceId.entries; since M5 added APPSERVICE, ReplayCorpus.replay errors with 'the replay corpus covers the polling sources (CR-2)' and the whole equivalence test fails. Pre-existing on main (fails with the #91 change stashed). Fix: restrict the loop to V2 and SLIDING (the appservice leg is covered by AppserviceInboundTest per D46). Also check why the CI build job did not catch it.
Correction to the body: CI did catch this — build run #253 (commit
35d2b4f, 2026-08-21) failed on SqliteReplayEquivalenceTest; the 'CI green' reading for that commit came from run #254, which is the spec-lint workflow. Each push produces two runs (build + spec-lint); the build run must be checked by job name. Fixed in7288cd9.