thecrealm/katrix
1
0
Fork 0
Code Issues 23 Pull requests Projects Releases Packages Wiki Activity Actions

createRoom injects the v12 default room_version (§3.7 / ADR-14) #138

New issue
Closed
opened 2026-08-27 19:21:10 +02:00 by thecrealm · 0 comments
thecrealm commented 2026-08-27 19:21:10 +02:00
Owner
Copy link

Review finding 2026-08-27 (A5). RoomVersions.DEFAULT_CREATE (v12) has zero production callers; KatrixSession.createRoom passes the body through unchanged, so the server's default decides.

Acceptance: createRoom sets room_version = RoomVersions.DEFAULT_CREATE.id unless the caller supplied one; test; §3.7 wording checked.

Review finding 2026-08-27 (A5). `RoomVersions.DEFAULT_CREATE` (v12) has zero production callers; `KatrixSession.createRoom` passes the body through unchanged, so the server's default decides. Acceptance: `createRoom` sets `room_version = RoomVersions.DEFAULT_CREATE.id` unless the caller supplied one; test; §3.7 wording checked.
thecrealm added
now
 and removed
next
 labels 2026-08-31 13:04:49 +02:00
thecrealm 2026-08-31 13:06:39 +02:00
  • closed this issue
  • removed the
    now
         label
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
spec-v1
Labels
Clear labels   
M0

   
M1

   
M2

   
M3

   
M4

   
M5

   
M6

   
blocked

   
next

   
now

   
priority
Jump the queue: work before other next items in the same milestone

No labels
M0
M1
M2
M3
M4
M5
M6
blocked
next
now
priority
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
thecrealm/katrix#138
No description provided.