Complete the SharedFlow-typed session lanes on close: outboundSends, aggregationUpdates, verificationRequests, metrics (§8) #172

New issue

Open

opened 2026-09-01 13:21:44 +02:00 by thecrealm · 0 comments

thecrealm commented

2026-09-01 13:21:44 +02:00

Owner

Found while adding the #143 stream-completion test (D89). §8: close() completes all public streams. The Flow-typed lanes (events, accountDataEvents, ephemeralEvents, toDeviceEvents, pushSignals, typedEvents) now complete on the closed signal; the SharedFlow-typed publics cannot complete by type: KatrixSession.outboundSends, aggregationUpdates, verificationRequests, metrics (and the fleet's equivalents, if any). Acceptance: re-type them to Flow (pre-1.0, apiDump), run them through untilClosed(), extend DeviceManagementTest.closeCompletesTheLanes to every public lane; §8 unchanged.

Found while adding the #143 stream-completion test (D89). §8: close() completes all public streams. The Flow-typed lanes (events, accountDataEvents, ephemeralEvents, toDeviceEvents, pushSignals, typedEvents) now complete on the closed signal; the SharedFlow-typed publics cannot complete by type: KatrixSession.outboundSends, aggregationUpdates, verificationRequests, metrics (and the fleet's equivalents, if any). Acceptance: re-type them to Flow<T> (pre-1.0, apiDump), run them through untilClosed(), extend DeviceManagementTest.closeCompletesTheLanes to every public lane; §8 unchanged.

thecrealm added the

labels

2026-09-01 13:22:10 +02:00

thecrealm referenced this issue from a commit

2026-09-01 13:41:24 +02:00

Device management + deactivation on the session, UIA by caller-supplied auth; close completes the Flow lanes (§10.2.3, §8, D89, closes #143)