CR-19: scan-style guard for key material and content across logs, toString, metrics and exceptions #156

Open
opened 2026-08-27 19:21:18 +02:00 by thecrealm · 0 comments
Owner

Review finding 2026-08-27 (D2). Six spot checks stand in for "never": the only KatrixLog.install in tests is on a crypto-less session; no toString assertions on InboundGroupSessionRecord, IdentityRecord, UtdRecord, SendItem; no metrics-stream scan; exception-chain scan covers three failures.

Acceptance (CR-19, §9): a log sink installed in SessionCryptoTest/UtdRedecryptorTest/BackupRestoreEndToEndTest grepping every line, every MetricEvent.toString() and every thrown chain for the session's pickles, megolm keys, recovery key and message markers; toString guards on every secret-bearing record.

Review finding 2026-08-27 (D2). Six spot checks stand in for "never": the only `KatrixLog.install` in tests is on a crypto-less session; no `toString` assertions on `InboundGroupSessionRecord`, `IdentityRecord`, `UtdRecord`, `SendItem`; no metrics-stream scan; exception-chain scan covers three failures. Acceptance (CR-19, §9): a log sink installed in `SessionCryptoTest`/`UtdRedecryptorTest`/`BackupRestoreEndToEndTest` grepping every line, every `MetricEvent.toString()` and every thrown chain for the session's pickles, megolm keys, recovery key and message markers; `toString` guards on every secret-bearing record.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
thecrealm/katrix#156
No description provided.