Sync loop failure typing: Stopped(typed cause) for unrecoverable protocol errors, malformed-batch retry through §5 with a §7 event (§10.3.4) #141

New issue

Closed

opened 2026-08-27 19:21:11 +02:00 by thecrealm · 1 comment

thecrealm commented

2026-08-27 19:21:11 +02:00

Owner

Review finding 2026-08-27 (A8). SyncLoop.kt:105-113: non-auth protocol errors (403/400/M_UNRECOGNIZED) back off forever; SyncState.Stopped/Backoff causes are Strings; malformed-batch retries use the private sleeper and only a log line, no MetricEvent.

Acceptance (§10.3.4, §7): typed cause on Backoff/Stopped; unrecoverable protocol errors stop with a typed cause; malformed-batch retry paced by §5 and reported as a metric event; tests asserting the observable Backoff state (none exist).

Review finding 2026-08-27 (A8). `SyncLoop.kt:105-113`: non-auth protocol errors (403/400/M_UNRECOGNIZED) back off forever; `SyncState.Stopped`/`Backoff` causes are Strings; malformed-batch retries use the private sleeper and only a log line, no `MetricEvent`. Acceptance (§10.3.4, §7): typed cause on `Backoff`/`Stopped`; unrecoverable protocol errors stop with a typed cause; malformed-batch retry paced by §5 and reported as a metric event; tests asserting the observable `Backoff` state (none exist).

thecrealm added the

labels

2026-08-27 19:21:56 +02:00

thecrealm commented

2026-08-27 20:02:44 +02:00

Author

Owner

Partial overlap landed with #134 / D81 (commit f624a99): the malformed-batch retry is now paced by the §5 schedule (retryPolicy.retryDelay(e, malformedStreak)) and SyncLoopRateLimitTest.malformedBatchRetriesUnderTheSection5Schedule asserts the observable Backoff state. Still open here: typed causes on Backoff/Stopped, unrecoverable protocol errors stopping with a typed cause, and the §7 metric event.

Partial overlap landed with #134 / D81 (commit f624a99): the malformed-batch retry is now paced by the §5 schedule (`retryPolicy.retryDelay(e, malformedStreak)`) and `SyncLoopRateLimitTest.malformedBatchRetriesUnderTheSection5Schedule` asserts the observable `Backoff` state. Still open here: typed causes on `Backoff`/`Stopped`, unrecoverable protocol errors stopping with a typed cause, and the §7 metric event.

thecrealm added

now

and removed

labels

2026-09-01 11:33:29 +02:00

thecrealm referenced this issue from a commit

2026-09-01 11:47:46 +02:00

Sync loop failure typing: sealed SyncFailure causes, a 4xx on /sync stops typed, malformed batches are §7 events (D87, closes #141)

thecrealm closed this issue

2026-09-01 11:47:46 +02:00